Repository navigation
[Feature] Improved Visualizer - #497
Conversation
unchihugo
left a comment
unchihugo
left a comment
There was a problem hiding this comment.
Hi @Hikaru11747, good performance improvements! The rounding change is a concern though — bars are now fully pill-shaped rather than the fixed radius users are already used to. Can you separate the rounding change so we can merge this performance refactor? Thanks!
|
I do understand the round pill concern, will it be better if I give an option customise it by the user? A drop down to select fully squared (no radius), fixed radius and pill as styles? |
That's true, and I had thought about this as well. That said, I've weighed the pros and cons extensively, and I think we should keep it as the original behavior for now: we're already presenting the user with quite the amount of customization options, and a new option could contribute to more fatigue or indecisiveness (I've already noticed that most users keep settings at default other than enabling/disabling features). I'd prefer we keep the current behavior, and see whether users would like a feature like this in the future. Feel free to open an issue about this! |
4e7f721 to
7673b63
Compare
unchihugo
left a comment
unchihugo
left a comment
There was a problem hiding this comment.
Great work, @Hikaru11747! Looks good now. I've tested the performance difference myself, and we're looking at about a ~5.5ms processing time @ 30fps, 10 bars (~12ms before your refactor) on my computer, so about 2.2x faster! Thanks for the improvement :)
2 participants
Improved how visualizer looks and feels, now using SDFs to draw the rounded corners (follows the win 11 rounded pill design), and optimized for better performance.